From be952509a102bd8db1e85175e3aad7cb5d6e8bdd Mon Sep 17 00:00:00 2001
From: NotII <46204250+NotII@users.noreply.github.com>
Date: Tue, 23 Sep 2025 22:41:27 +0100
Subject: [PATCH] Improve ProductSelector response handling and UI

Enhanced the ProductSelector to robustly handle different response shapes from the products API, preventing runtime errors. Also adjusted dropdown and scroll area sizing for better UI consistency.
---
 .../dashboard/promotions/ProductSelector.tsx     | 16 ++++++++++++----
 public/git-info.json                             |  4 ++--
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/components/dashboard/promotions/ProductSelector.tsx b/components/dashboard/promotions/ProductSelector.tsx
index a0e4422..27bc2b2 100644
--- a/components/dashboard/promotions/ProductSelector.tsx
+++ b/components/dashboard/promotions/ProductSelector.tsx
@@ -50,7 +50,15 @@ export default function ProductSelector({
       setLoading(true);
       try {
         const response = await fetchClient('/promotions/products/all');
-        setProducts(response);
+        // Ensure we only set an array to state to avoid runtime errors
+        if (Array.isArray(response)) {
+          setProducts(response);
+        } else if (response && Array.isArray((response as any).products)) {
+          setProducts((response as any).products);
+        } else {
+          console.error('Unexpected products response shape:', response);
+          setProducts([]);
+        }
       } catch (error) {
         console.error('Error fetching products:', error);
       } finally {
@@ -119,8 +127,8 @@ export default function ProductSelector({
         {/* Dropdown using absolute positioning within relative container */}
         {open && (
           <div 
-            className="absolute top-full left-0 right-0 z-50 mt-1 bg-background border border-border rounded-md shadow-lg max-h-64 overflow-hidden"
-            style={{ minWidth: '300px' }}
+            className="absolute top-full left-0 right-0 z-50 mt-1 bg-background border border-border rounded-md shadow-lg"
+            style={{ minWidth: '300px', maxHeight: '400px' }}
           >
             {/* Search Header */}
             <div className="flex items-center gap-2 p-3 border-b bg-muted/30">
@@ -135,7 +143,7 @@ export default function ProductSelector({
             </div>
             
             {/* Products List */}
-            <ScrollArea className="max-h-48">
+            <ScrollArea className="h-[300px]">
               {loading ? (
                 <div className="p-4 text-center text-sm text-muted-foreground">
                   Loading products...
diff --git a/public/git-info.json b/public/git-info.json
index ba3d780..d8bfb67 100644
--- a/public/git-info.json
+++ b/public/git-info.json
@@ -1,4 +1,4 @@
 {
-  "commitHash": "8554481",
-  "buildTime": "2025-09-17T17:02:11.044Z"
+  "commitHash": "74b7aa4",
+  "buildTime": "2025-09-23T12:09:08.230Z"
 }
\ No newline at end of file